Updating the mysql2_mysql_enc_to_rb conversion table to 8.0 List #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck to make sure we do not go out of bounds.
|
@sodabrew It looks like the Travis build is failing to download some dependencies. |
|
Thanks for worrying on the MySQL 5.5 build - I'm OK merging this without fixing Travis for that version. |
|
This PR looks good to me! Is there anything else you want to do on this branch before I merge it? |
|
@sodabrew nope it's all good from my side. |
jeremy
added a commit
to jeremy/mysql2
that referenced
this pull request
Mar 5, 2019
* upstream/master: Expose windows client authentication (brianmario#1018) Fix code snippet (brianmario#1002) Add CentOS on Travis CI. (brianmario#989) Bump version to 0.5.2 Travis apt-get update for MySQL 5.5 install Updating the mysql2_mysql_enc_to_rb conversion table to 8.0 List (brianmario#976) Add default-libmysqlclient-dev to the likely packages list Bump version to 0.5.1 Use the prepared statement performance schema if available (brianmario#960) README mysql2 0.5.x works with Rails 5.0.7, 5.1.6, and higher README be sure to read about the known limitations of prepared statements Add missing FREE_BINDS to prepared statement streaming error case (brianmario#958) Fix with --with-mysql-dir (brianmario#952) Prevent command out of sync errors with Prepared Statements (brianmario#958)
hanachin
added a commit
to agileware-jp/redmine-plugin-orb
that referenced
this pull request
Jul 23, 2019
mysql2 gem > 0.5.2 doesn't support MySQL 8.0 brianmario/mysql2#976
fkdkent
pushed a commit
to agileware-jp/redmine-plugin-orb
that referenced
this pull request
Jul 25, 2019
* Move -ram suffix to the parameter * Use MySQL 5.x for ruby >= 2.4 mysql2 gem > 0.5.2 doesn't support MySQL 8.0 brianmario/mysql2#976
kamibayashi
pushed a commit
to kamibayashi/mysql2
that referenced
this pull request
Mar 7, 2023
…anmario#976) Also add a check to make sure we do not go out of bounds.
hkmaly
pushed a commit
to ipdgroup/mysql2
that referenced
this pull request
Oct 9, 2024
…anmario#976) Also add a check to make sure we do not go out of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #975 what happened is that I used the collation utf8mb4_general_ci which is listed as charsetnr 254 in the C API our conversion table mysql2_mysql_enc_to_rb did not have entries that went past 245 previously. Thus, functions that used the result of this selection would be given an index into undefined memory and when they tried to read it they would blow past the end of the segment causing the issue in #975. I've added a check to return NULL if we see a charsetnr that is larger than the conversion table.