Add tests specifically for #2604 and #3050

briannesbitt · Jul 15, 2024 · 37b3bd5 · 37b3bd5
1 parent 4d3f401
commit 37b3bd5
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/tests/Carbon/DiffTest.php b/tests/Carbon/DiffTest.php
@@ -2042,6 +2042,23 @@ public function testPHPBug80974()
         $this->assertSame(1, Carbon::parse('2018-07-01')->diffAsDateInterval(Carbon::parse('2018-07-02')->utc())->days);
     }
 
+    public function testThreeMonthMinusOneDay()
+    {
+        $start = new Carbon('2022-11-11 22:29:50.000000');
+        $end = $start->copy()->addMonths(3);
+        $now = $start->copy()->addDay();
+
+        $this->assertSame(3.0, $start->diffInMonths($end));
+        $this->assertSame(3 - 1 / 31, $now->diffInMonths($end));
+
+        $start = new Carbon('2022-04-11 22:29:50.000000');
+        $end = $start->copy()->addMonths(3);
+        $now = $start->copy()->addDay();
+
+        $this->assertSame(3.0, $start->diffInMonths($end));
+        $this->assertSame(3 - 1 / 30, $now->diffInMonths($end));
+    }
+
     public function testDiffWithZeroAndNonZeroMicroseconds()
     {
         $requestTime = new Carbon('2018-11-14 18:23:12.0 +00:00');

diff --git a/tests/Carbon/GettersTest.php b/tests/Carbon/GettersTest.php
@@ -238,6 +238,13 @@ public function testGetAgeWithRealAge()
         $this->assertSame($age, $d->age);
     }
 
+    public function testAgeWithBirthdayTomorrowAndLeapYear()
+    {
+        Carbon::setTestNow('2024-07-15 22:15');
+
+        $this->assertSame(3, Carbon::parse('2020-07-16')->age);
+    }
+
     public static function dataForTestQuarter(): array
     {
         return [

diff --git a/tests/CarbonImmutable/DiffTest.php b/tests/CarbonImmutable/DiffTest.php
@@ -1864,6 +1864,23 @@ public function testPHPBug80974()
         $this->assertSame(1, Carbon::parse('2018-07-01')->diffAsDateInterval(Carbon::parse('2018-07-02')->utc())->days);
     }
 
+    public function testThreeMonthMinusOneDay()
+    {
+        $start = new Carbon('2022-11-11 22:29:50.000000');
+        $end = $start->addMonths(3);
+        $now = $start->addDay();
+
+        $this->assertSame(3.0, $start->diffInMonths($end));
+        $this->assertSame(3 - 1 / 31, $now->diffInMonths($end));
+
+        $start = new Carbon('2022-04-11 22:29:50.000000');
+        $end = $start->addMonths(3);
+        $now = $start->addDay();
+
+        $this->assertSame(3.0, $start->diffInMonths($end));
+        $this->assertSame(3 - 1 / 30, $now->diffInMonths($end));
+    }
+
     public function testDiffWithZeroAndNonZeroMicroseconds()
     {
         $requestTime = new Carbon('2018-11-14 18:23:12.0 +00:00');