-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPStan extension for macros #1916
Conversation
Yep, that's the idea. Thanks a lot. 🥇 |
@kylekatarnls i am not too familiar with the inner workings of PHPStan, this is taking me longer than i thought. There is a whole bunch of abstractions in Larastan that seem unnecessary for us, i tried to strip them away to keep the code as simple as it can be. Can you take a look and see if you can work with what i have so far? I got the test to a point where it produces usable output, at least. |
I had some tries but's it's indeed a bit more difficult than I expected. I postpone this for version 2.27. |
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1994 2027 +33
===========================================
Files 883 885 +2
Lines 8836 8899 +63
===========================================
+ Hits 8836 8899 +63
Continue to review full report at Codecov.
|
Apply fixes from StyleCI
This extension is ready to be tested: Require this branch in an app using:
Require phpstan + extension-installer:
And finally, add the file loading your macros and mixins in the parameters:
bootstrapFiles:
- config/bootstrap.php |
Awesome work @kylekatarnls, i tested according to your suggestion. Works perfectly. |
Resolves #1846
Just threw together a WIP (nothing works atm), taking parts from larastan/larastan#301 and Larastan.
@kylekatarnls is this the direction you want this to go?