Fix polish translation causing a runtime error #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample manifestation of the bug is described in the followin issue: firefly-iii/firefly-iii#4845
|
Indeed, no translation should have only 2 plural form in PL files. |
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 886 886
Lines 9191 9191
=========================================
Hits 9191 9191
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that PL translations provide 3 variants, depending on
:countparam value, but the "short year" translation provides only two, which causes a runtime error.I don't know PHP, so I am not able to provide (in reasonable time) reproduction steps other than the actual use where I spotted the problem. Sample manifestation of the bug is described in the following issue:
firefly-iii/firefly-iii#4845