Use a Github Action to check for code style #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a Github Action as a replacement for StyleCI.
StyleCI has been introduced 6 years ago when Github Actions were not a thing yet, and has done its job well.
Since then Github Action has been introduced and provide a greater flexibility and we can use only PHP-CS-Fixer.
This way we can
.php-cs-fixer.dist.phpfileetc...
Cf. code-check : https://github.com/briannesbitt/Carbon/pull/2429/checks?check_run_id=3400609992
After this PR is merged, this repo should be disabled in StyleCI admin