Fix CreateFromTimeTest #2563
Merged
Fix CreateFromTimeTest #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default timezone
kylekatarnls
added
the
details needed
kylekatarnls
removed
the
details needed
kylekatarnls
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test when timezone is specified,
Carbon::now()is used to calculate the expected date. If the test is run in an environment that defaults to a timezone other than the 'Europe/London' specified in the test, the test may fail because the dates obtained will be different for some hours of the day.Specifying the time zone when asking for the expected date solves this problem.