Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kurdish (sorani) language #2571

Merged
merged 5 commits into from
Apr 3, 2022
Merged

add kurdish (sorani) language #2571

merged 5 commits into from
Apr 3, 2022

Conversation

swarakaka
Copy link
Contributor

No description provided.

@swarakaka
correction
58410d6 
Correct some incorrectly translated words
@swarakaka swarakaka requested a review from kylekatarnls March 25, 2022 10:42
jwtiyar
jwtiyar approved these changes Mar 25, 2022
View reviewed changes
Copy link

@jwtiyar jwtiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me.

rojvv
rojvv approved these changes Mar 25, 2022
View reviewed changes
Copy link

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylekatarnls
Copy link
Collaborator

Hello, I generated a test file for this new locale:
https://github.com/briannesbitt/Carbon/pull/2571/files#diff-a954a82a5b73e9e252be75f4fbdd4418ec4211cf8e2a2d10d1760dcee203b6e3

Please check that output would be globally fine for the given code snippet (in comment above each result line).

@swarakaka
Copy link
Contributor Author

Hello, I generated a test file for this new locale: https://github.com/briannesbitt/Carbon/pull/2571/files#diff-a954a82a5b73e9e252be75f4fbdd4418ec4211cf8e2a2d10d1760dcee203b6e3

Please check that output would be globally fine for the given code snippet (in comment above each result line).

thanks for the test. I noticed a few wrong translations that I will fix.

@kylekatarnls kylekatarnls added this to the 2.58.0 milestone Apr 3, 2022
@kylekatarnls kylekatarnls added the translation Rely to internationalization label Apr 3, 2022
@kylekatarnls kylekatarnls merged commit a920ad4 into briannesbitt:master Apr 3, 2022
@rojvv
Copy link

rojvv commented Apr 3, 2022

Awesomely done. @swara-mohammed! Thank you too, @kylekatarnls!

This was referenced May 3, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls approved these changes

@rojvv rojvv rojvv approved these changes

@jwtiyar jwtiyar jwtiyar approved these changes

Assignees
No one assigned
Labels
translation Rely to internationalization
Projects
None yet
Milestone
2.58.0
Development

Successfully merging this pull request may close these issues.
4 participants
@swarakaka @kylekatarnls @rojvv @jwtiyar