Print original params in Carbon\Traits\Units::addUnit error message #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter, but will instead provide the current value. The parameter "$unit" was changed in previous lines. So the exception message contains the changed value. This commit preserves the original arguments in variable to be eventually used in the error message.
kylekatarnls
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 7.0, functions inspecting arguments, like func_get_args(), no longer report the original value as passed to a parameter but will instead provide the current value.
The parameter
$unitwas changed in previous lines. So the exception message contains the changed value.I assume that it is nicer to print the original values so that the user of the library knows which value caused the issue.
This PR preserves the original arguments in a variable to be eventually used in the error message.