Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lowercase macro-format per-language customization #2683

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Allow lowercase macro-format per-language customization #2683

merged 1 commit into from
Oct 17, 2022

Conversation

kylekatarnls
Copy link
Collaborator

Fix #2679

@kylekatarnls kylekatarnls added the translation Rely to internationalization label Oct 9, 2022
@kylekatarnls kylekatarnls added this to the 2.63.0 milestone Oct 9, 2022
@kylekatarnls kylekatarnls merged commit d61ab74 into briannesbitt:master Oct 17, 2022
@kylekatarnls kylekatarnls deleted the fix/issue-2679-allow-lower-macro-format-per-language-customization branch October 17, 2022 14:45
@cbaconnier
Copy link

I think it broke the date format I was using.

$date->isoFormat('Ll');

The expected output was 01 janv. 2020 (French) but since the last update I'm getting 01/01/2020

@kylekatarnls
Copy link
Collaborator Author

Hello, mixed case was never intended to provide any particular output, ll will give you the same output as Ll before this fix:

1 janv. 2020

(in both case, there is no trailing 0)

@cbaconnier
Copy link

Thanks! I suppose it was a typo on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
translation Rely to internationalization
Projects
None yet
Milestone
2.63.0
Development

Successfully merging this pull request may close these issues.

Issue with isoFormat('ll') when using 'months_short' as it adds "ta" suffix
2 participants
@kylekatarnls @cbaconnier