Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate ordinal word when parsing string #2693

Merged

Conversation

kylekatarnls
Copy link
Collaborator

Fix #2692

@kylekatarnls kylekatarnls added enhancement translation Rely to internationalization labels Oct 30, 2022
@kylekatarnls kylekatarnls added this to the 2.63.0 milestone Oct 30, 2022
@kylekatarnls kylekatarnls force-pushed the feature/issue-2692-ordinal-words branch from 7e2c7bc to 85a99ae Compare October 30, 2022 10:47
@kylekatarnls kylekatarnls marked this pull request as ready for review October 30, 2022 10:49
@kylekatarnls kylekatarnls merged commit 5660ebb into briannesbitt:master Oct 30, 2022
@kylekatarnls kylekatarnls deleted the feature/issue-2692-ordinal-words branch October 30, 2022 11:06
@juniorb2ss
Copy link

Why was this considered a minor change and not a bump change? e.g: breaking change reported: #2716

@kylekatarnls
Copy link
Collaborator Author

kylekatarnls commented Dec 6, 2022

Please read https://github.com/briannesbitt/Carbon/blob/master/contributing.md#note-about-semantic-versioning-and-breaking-changes

We can't possibly guess all the usage combinations and you can see how wide is already our list of tests https://github.com/briannesbitt/Carbon/tree/master/tests (we cover quite a lot of use cases).

Carbon::createFromLocaleFormat('d \d\e F \d\e Y', 'es' ...) is not a widely used case else we would have way more than 1 report since it was released.

Please keep in mind this software is open-source and provided for free, it is what contributors put in it. Review and BC-finding is made in best effort by the community offering time to build features.

Now we can't possibly just revert #2693 as it would be an even harder BC.

If you can provide a fix to support Carbon::createFromLocaleFormat('d \d\e F \d\e Y', 'es' ...) without breaking other tests, I would gladly review it.

Thanks.

@kylekatarnls
Copy link
Collaborator Author

Fix #2719 merged

@juniorb2ss
Copy link

Thank you @kylekatarnls! I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement translation Rely to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translation tool] es_ES
3 participants