Dynamic first/last day of week and weekend days #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Israel, week starts at Sunday and ends at Saturday, weekend days are Friday and Saturday and many other countries has their own weekends and weird calendars.. so I think it might help others Added: protected static $weekStartsAt integer (use Carbon::DAYCONST) protected static $weekEndsAt integer (use Carbon::DAYCONST) protected static $weekendDays array (array of Carbon::DAYCONST) public static function getWeekStartsAt() public static function setWeekStartsAt($day) public static function getWeekEndsAt() public static function setWeekEndsAt($day) public static function getWeekendDays() public static function setWeekendDays($days) Updated: isWeekday() - to use !$this->isWeekend() isWeekend() - to check if current day is in static::$weekendDays startOfWeek() - to use static::$weekStartsAt endOfWeek() - to use static::$weekEndsAt
|
If you accept this one, the next level would be to automate it with locales |
briannesbitt
added a commit
that referenced
this pull request
Jun 13, 2015
Dynamic first/last day of week and weekend days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Israel, week starts at Sunday and ends at Saturday, weekend days are Friday and Saturday
and many other countries has their own weekends and weird calendars.. so I think it might help others
Added:
protected static $weekStartsAt integer (use Carbon::DAYCONST)
protected static $weekEndsAt integer (use Carbon::DAYCONST)
protected static $weekendDays array (array of Carbon::DAYCONST)
public static function getWeekStartsAt()
public static function setWeekStartsAt($day)
public static function getWeekEndsAt()
public static function setWeekEndsAt($day)
public static function getWeekendDays()
public static function setWeekendDays($days)
Updated:
isWeekday() - to use !$this->isWeekend()
isWeekend() - to check if current day is in static::$weekendDays
startOfWeek() - to use static::$weekStartsAt
endOfWeek() - to use static::$weekEndsAt