forked from dart-lang/native
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[native_assets_cli] Cleanup constructors (dart-lang#1867)
Addresses: * dart-lang#1824 (comment) @mkustermann Do you prefer repeating the arguments to `CodeConfig` in `setupCodeConfig` leading to the following? ```dart ..setupCodeConfig( targetArchitecture: Architecture.current, targetOS: OS.current, macOSConfig: targetOS == OS.macOS ? MacOSConfig(targetVersion: defaultMacOSVersion) : null, linkModePreference: LinkModePreference.dynamic, ); ``` Or rather avoiding to repeat the arguments and have the following? ```dart ..setupCodeConfig(CodeConfig( targetArchitecture: Architecture.current, targetOS: OS.current, macOSConfig: targetOS == OS.macOS ? MacOSConfig(targetVersion: defaultMacOSVersion) : null, linkModePreference: LinkModePreference.dynamic, )); ``` I've done the former now, but can easily revert that commit.
- Loading branch information
Showing
1 changed file
with
60 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters