32-bit ARM AES-GCM: Fix use of BSAES. #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoringSSL split up there bn_tests.txt into multiple files, which we had done previously. Prepare to merge that BoringSSL change by putting the test input files in the same places.
The slice indexing was wrong. CI did not catch this because it only uses the implementations that the feature detection logic chooses, and in CI it uses the emulator that always chooses the hardware AES implementation. The consequence is that on 32-bit ARM targets with NEON but without hardware AES, the encryption/decryption is done incorrectly. The change that introduced this problem was 74aa79b. I checked (and tested) the latest release (0.16.20) to verify that it is correct. So this only affects 0.17, which wasn't been released yet. The fix mirrors what we were doing before in 0.16.20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit message.