ECDSA verification: Refactor a*g + b*p multiplication #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkrasnov PTAL. |
Codecov Report
@@ Coverage Diff @@
## main #1757 +/- ##
==========================================
+ Coverage 95.93% 95.98% +0.04%
==========================================
Files 138 138
Lines 20610 20691 +81
Branches 221 226 +5
==========================================
+ Hits 19772 19860 +88
+ Misses 800 792 -8
- Partials 38 39 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
briansmith
force-pushed
the
b/twin-mul-1
branch
from
a44ea32
to
36540de
Compare
Allow each curve to provide its own `twin_mul` implementation. For now, use the same implementation we've been using.
From BoringSSL commit 8d71d24. Comment it out until it is modified to work.
briansmith
force-pushed
the
b/twin-mul-1
branch
3 times, most recently
from
86f4976
to
3d04b83
Compare
Import the optimized nistz256 verification from BoringSSL.
Move more of the logic for the nistz256 multiplication into Rust.
briansmith
force-pushed
the
b/twin-mul-1
branch
from
3d04b83
to
107c046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the nistz256 implementation should be doing this multiplication in the naïve way. Even then, we should be using the optimized variable-time implementation from BoringSSL, so bring it in and use it.
After this PR, we can more easily replace
twin_mul_inefficientwith a proper twin multiplication implementation that works for any curve.See the individual commit messages to see the changes made to the imported BoringSSL code; the second commit imports it unmodified, and the third commit makes the needed changes.