Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test on ARM Android. #177

Closed
wants to merge 1 commit into from

Conversation

pietro
Copy link
Contributor

@pietro pietro commented May 18, 2016

No description provided.

- openjdk-6-jre-headless

- env: TARGET_X=arm-linux-androideabi CC_X=arm-linux-androideabi-gcc CXX_X=arm-linux-androideabi-g++ MODE_X=DEBUG KCOV=0
rust: nightly
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the rust: nightly + MODE_X=RELWITHDEBINFO option. Please add it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@briansmith
Copy link
Owner

Please add the "I agree..." statement to the commit message (wrapped at 72 characters) and address the two nits.

This looks awesome!

@pietro pietro force-pushed the android_build branch 2 times, most recently from 95dbf88 to 7b379d6 Compare May 18, 2016 04:07
@pietro
Copy link
Contributor Author

pietro commented May 18, 2016

I added the wrapped "I agree..." statement to the commit message. I didn't add it as a comment to the PR though.

@pietro pietro mentioned this pull request May 18, 2016
5 tasks
@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage decreased (-0.02%) to 63.799% when pulling 7b379d622a9f8447d9a940fa271f9e00106c9c79 on pietro:android_build into d731947 on briansmith:master.

@briansmith
Copy link
Owner

Unfortunately, the build fails:

+adb wait-for-device
+emulator64-arm @arm-18 -no-audio -no-window
emulator64-arm: error while loading shared libraries: libQt5Widgets.so.5: cannot open shared object file: No such file or directory
* daemon not running. starting it now on port 5037 *
* daemon started successfully *

@pietro
Copy link
Contributor Author

pietro commented May 18, 2016

Weird I haven't had that issue both locally and on travis. I'll do some more testing.

I agree to license my contributions to each file under the terms given
at the top of each file I changed.
@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage remained the same at 63.815% when pulling e58c152 on pietro:android_build into d731947 on briansmith:master.

@pietro
Copy link
Contributor Author

pietro commented May 19, 2016

Sorry. I fixed the build and added a few things:

  1. travis_wait to the android builds because the long running tests on release builds.
  2. logic to copy the right binary (debug or release) to the emulator image.

@briansmith can you please review those? thanks.

@briansmith
Copy link
Owner

Awesome! Thanks! Landed as 72616bb.

@briansmith briansmith closed this May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants