-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test on ARM Android. #177
Conversation
- openjdk-6-jre-headless | ||
|
||
- env: TARGET_X=arm-linux-androideabi CC_X=arm-linux-androideabi-gcc CXX_X=arm-linux-androideabi-g++ MODE_X=DEBUG KCOV=0 | ||
rust: nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the rust: nightly
+ MODE_X=RELWITHDEBINFO
option. Please add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Please add the "I agree..." statement to the commit message (wrapped at 72 characters) and address the two nits. This looks awesome! |
95dbf88
to
7b379d6
Compare
I added the wrapped "I agree..." statement to the commit message. I didn't add it as a comment to the PR though. |
Coverage decreased (-0.02%) to 63.799% when pulling 7b379d622a9f8447d9a940fa271f9e00106c9c79 on pietro:android_build into d731947 on briansmith:master. |
Unfortunately, the build fails:
|
Weird I haven't had that issue both locally and on travis. I'll do some more testing. |
I agree to license my contributions to each file under the terms given at the top of each file I changed.
Sorry. I fixed the build and added a few things:
@briansmith can you please review those? thanks. |
Awesome! Thanks! Landed as 72616bb. |
No description provided.