montgomery: Do runtime length checking during Montgomery multiplication. #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 96.02% 95.96% -0.06%
==========================================
Files 136 137 +1
Lines 20717 20709 -8
Branches 226 226
==========================================
- Hits 19893 19873 -20
- Misses 790 802 +12
Partials 34 34 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/bn_mul_mont-2
branch
3 times, most recently
from
7629aff
to
e16defd
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/bn_mul_mont-2
branch
from
e16defd
to
780ed2e
Compare
Always enforce the bounds checks for `bn_mul_mont`.
Further clarify the memory safety.
briansmith
force-pushed
the
b/bn_mul_mont-2
branch
from
780ed2e
to
9a393e1
Compare
|
Rebased on main after #1856 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our expectation is that these checks will never trigger errors because the prerequisites are always checked. However, the checks don't cost anything significant and this clarifies the memory safety.