Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fe_isnonzero to fe_isnonzero_vartime #1893

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor fe_isnonzero to fe_isnonzero_vartime #1893

wants to merge 7 commits into from

Commits on Jan 11, 2024

  1. Refactor fe_isnonzero to fe_isnonzero_vartime 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9962055 View commit details
    Browse the repository at this point in the history

  2. Update verify_slices_are_equal not use CRYPTO_memcmp 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    eb530d1 View commit details
    Browse the repository at this point in the history

  3. fixup test 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6510eb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. revert all previous commits 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    b9a275c View commit details
    Browse the repository at this point in the history

  2. address comment 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    e7143af View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'main' into fe_isnonzero_vartime

    @tisonkun
    tisonkun committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8aba2ef View commit details
    Browse the repository at this point in the history

  2. fe_isnonzero_vartime is not constant-time fn 

    Signed-off-by: tison <wander4096@gmail.com>
    @tisonkun
    tisonkun committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    407599a View commit details
    Browse the repository at this point in the history