Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes: Clarify counter overflow checking. #2120

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

aes-gcm: Provide more descriptive errors in internal API.

812ebfc
Select commit
Loading
Failed to load commit list.
Open

aes: Clarify counter overflow checking. #2120

aes-gcm: Provide more descriptive errors in internal API.
812ebfc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 28, 2024 in 0s

97.04% (-0.09%) compared to fd06b00

View this Pull Request on Codecov

97.04% (-0.09%) compared to fd06b00

Details

Codecov Report

Attention: Patch coverage is 93.73737% with 31 lines in your changes missing coverage. Please review.

Project coverage is 97.04%. Comparing base (fd06b00) to head (812ebfc).

Files Patch % Lines
src/aead/aes_gcm.rs 81.91% 17 Missing ⚠️
src/aead/gcm.rs 41.66% 7 Missing ⚠️
src/aead/aes/counter.rs 99.23% 1 Missing and 1 partial ⚠️
src/aead/aes/ffi.rs 81.81% 1 Missing and 1 partial ⚠️
src/aead/aes/vp.rs 96.87% 2 Missing ⚠️
src/aead/aes.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   97.12%   97.04%   -0.09%     
==========================================
  Files         151      152       +1     
  Lines       20101    20475     +374     
  Branches      447      454       +7     
==========================================
+ Hits        19524    19870     +346     
- Misses        482      508      +26     
- Partials       95       97       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.