ec/suite_b: Make more LeakyLimb->Limb conversions explicit. #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clearer that it is a variable-time operation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
- Coverage 96.93% 96.92% -0.01%
==========================================
Files 154 154
Lines 20157 20195 +38
Branches 464 464
==========================================
+ Hits 19539 19575 +36
Misses 512 512
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/publicmodulus
branch
from
37ed24a to
82ada79
Compare
Rename `Modulus` to `PublicModulus` and add a new `Modulus`:
PublicModulus::limbs: [LeakyLimb; _]
Modulus::limbs: [Limb; _]
Refactor the callers to (approximately) minimize the number of
types a `Modulus` is constructed, as it will require a copy if/when
`Limb` becomes a type distinct from `LeakyLimb`.
(In the future, it is likely that more methods of `CommonOps` and
`ScalarOps` will move to `Modulus<Q>` and `Modulus<N>`,
respectively.)
briansmith
force-pushed
the
b/publicmodulus
branch
from
82ada79 to
d7a133b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
ModulustoPublicModulusand add a newModulus:Refactor the callers to (approximately) minimize the number of types a
Modulusis constructed, as it will require a copy if/whenLimbbecomes a type distinct fromLeakyLimb.