Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run aarch64 android tests on travis. #783

Closed
wants to merge 2 commits into from

Conversation

pietro
Copy link
Contributor

@pietro pietro commented Feb 1, 2019

Closes #486.

I agree to license my contributions to each file under the terms given
at the top of each file I changed.
@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling bf24cff on pietro:aarch64_android_travis into 050d616 on briansmith:master.

@coveralls
Copy link

coveralls commented Feb 1, 2019

Coverage Status

Coverage increased (+2.2%) to 93.617% when pulling 31860f7 on pietro:aarch64_android_travis into 050d616 on briansmith:master.

I agree to license my contributions to each file under the terms given
at the top of each file I changed.
@pietro
Copy link
Contributor Author

pietro commented Mar 6, 2019

@briansmith I suspect this will work if you clear the build caches in travis. I'm sorry I haven't had time to look into improving the android sdk/ndk install to auto clear the cache.

@briansmith
Copy link
Owner

@pietro Thanks for your work on this.

Even after I cleared the build caches and whatnot, I couldn't get it to work.

I think we should try to get the emulator-based tests for AAarch64 Android running on top of the current (just changed) Android CI setup, which would require a very different PR. If we really have to resort to manually downloading the NDK and/or emulator to get this working then we'll do so, but I'd like that to be done only as a last resort.

A silver lining: I now finally understand more or less how the Android toolchain works and so I should be able to review future Android-targeted changes much faster.

With that in mind, I'm going to close this unless/until we can figure out a new PR that works reliably.

Thanks again for your amazing help with this and other CI issues! Really your help has been amazing.

@briansmith briansmith closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test aarch64-linux-android in emulator
3 participants