Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error::UnsupportedCertVersion instead of BadDER on certificate v1 #184

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

stepancheg
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #184 (70d2d4a) into main (07306a6) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   71.32%   71.78%   +0.45%     
==========================================
  Files          15       16       +1     
  Lines        1395     1414      +19     
==========================================
+ Hits          995     1015      +20     
+ Misses        400      399       -1     
Impacted Files Coverage Δ
src/cert.rs 95.93% <100.00%> (+0.13%) ⬆️
src/trust_anchor.rs 98.41% <100.00%> (ø)
tests/cert_v1_unsupported.rs 100.00% <100.00%> (ø)
src/name/verify.rs 4.14% <0.00%> (+0.02%) ⬆️
src/der.rs 91.47% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07306a6...557c0f2. Read the comment docs.

@stepancheg stepancheg force-pushed the v1 branch 2 times, most recently from 1803ae7 to 4a2a668 Compare February 16, 2021 05:34
@briansmith
Copy link
Owner

LGTM. Please append a blank line and then contributor's license statement "I agree to license my contributions to each file under the terms given at the top of each file I changed." to the commit message body (not the pull request summary).

@stepancheg
Copy link
Contributor Author

Updated the commit message.

@stepancheg
Copy link
Contributor Author

Updated the PR to do peek to avoid incorrectly reporting UnsupportedCertVersion on malformed DER, as pointed out in a comment in another PR.

src/cert.rs Outdated Show resolved Hide resolved
I agree to license my contributions to each file under the terms given at the top of each file I changed.
@stepancheg
Copy link
Contributor Author

Reverted to the previous version and update the field documentation.

@briansmith briansmith merged commit 1364e7a into briansmith:main Feb 17, 2021
@briansmith
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants