Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error::UnsupportedCertWithoutExtensions #185

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

stepancheg
Copy link
Contributor

Better error than BadDER when certificate is generated incorrectly.

I agree to license my contributions to each file under the terms given at the top of each file I changed.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #185 (1a75f73) into main (07306a6) will increase coverage by 0.29%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   71.32%   71.62%   +0.29%     
==========================================
  Files          15       16       +1     
  Lines        1395     1399       +4     
==========================================
+ Hits          995     1002       +7     
+ Misses        400      397       -3     
Impacted Files Coverage Δ
src/error.rs 86.66% <0.00%> (+20.00%) ⬆️
src/cert.rs 95.79% <100.00%> (ø)
tests/cert_without_extensions.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07306a6...1a75f73. Read the comment docs.

src/cert.rs Outdated Show resolved Hide resolved
tests/cert_without_extensions.rs Outdated Show resolved Hide resolved
tests/cert_without_extensions.rs Outdated Show resolved Hide resolved
tests/cert_without_extensions.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
Better error than `BadDER` when certificate is generated incorrectly.

I agree to license my contributions to each file under the terms given at the top of each file I changed.
@stepancheg
Copy link
Contributor Author

Renamed to MissingOrMalformedExtensions and removed peek.

@briansmith briansmith merged commit ba54ede into briansmith:main Feb 17, 2021
@briansmith
Copy link
Owner

Thanks!

@stepancheg stepancheg deleted the no-ext branch February 17, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants