Corona: Add stricter type to client data http exception data input

Reviewed at https://reviews.lunr.nl/r/1193/
brianstoop · Jul 12, 2024 · 05950ca · 05950ca
1 parent e193926
commit 05950ca
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/src/Lunr/Corona/Exceptions/ClientDataHttpException.php b/src/Lunr/Corona/Exceptions/ClientDataHttpException.php
@@ -25,9 +25,9 @@ abstract class ClientDataHttpException extends HttpException
 
     /**
      * Input data value
-     * @var mixed
+     * @var null|scalar
      */
-    protected $value;
+    protected null|string|int|float|bool $value;
 
     /**
      * Report data
@@ -51,12 +51,12 @@ public function __construct(?string $message = NULL, int $code = 0, int $app_cod
     /**
      * Set input data that caused the request.
      *
-     * @param string $key   Key/URL parameter name
-     * @param mixed  $value Input value
+     * @param string      $key   Key/URL parameter name
+     * @param null|scalar $value Input value
      *
      * @return void
      */
-    public function setData(string $key, $value): void
+    public function setData(string $key, null|string|int|float|bool $value): void
     {
         $this->key   = $key;
         $this->value = $value;
@@ -117,9 +117,9 @@ public function getDataKey(): ?string
     /**
      * Get the input data value.
      *
-     * @return mixed Input data value
+     * @return null|scalar Input data value
      */
-    public function getDataValue()
+    public function getDataValue(): null|string|int|float|bool
     {
         return $this->value;
     }

diff --git a/src/Lunr/Corona/Exceptions/Tests/BadRequestExceptionBaseTest.php b/src/Lunr/Corona/Exceptions/Tests/BadRequestExceptionBaseTest.php
@@ -34,14 +34,6 @@ public function testApplicationErrorCodeSetCorrectly(): void
         $this->assertPropertySame('app_code', $this->code);
     }
 
-    /**
-     * Test that the input data value was set correctly.
-     */
-    public function testInputDataValueIsNull(): void
-    {
-        $this->assertNull($this->get_reflection_property_value('value'));
-    }
-
     /**
      * Test that the input data flag was set correctly.
      */

diff --git a/src/Lunr/Corona/Exceptions/Tests/ForbiddenExceptionBaseTest.php b/src/Lunr/Corona/Exceptions/Tests/ForbiddenExceptionBaseTest.php
@@ -34,14 +34,6 @@ public function testApplicationErrorCodeSetCorrectly(): void
         $this->assertPropertySame('app_code', $this->code);
     }
 
-    /**
-     * Test that the input data value was set correctly.
-     */
-    public function testInputDataValueIsNull(): void
-    {
-        $this->assertNull($this->get_reflection_property_value('value'));
-    }
-
     /**
      * Test that the error message was passed correctly.
      */