BigNumber::of performance update

[SebastienDug]

1. Split regex for Rational and Numerical
2. Exception method is static to the class instead of being created dynamically for each call to BigNumber::of
3. Added flag to pregMatch to return no matches as NULL instead of manipulating empty string and converting it to null
4. leanCleanup introduced as there was a concatenation of sign to pass to the cleanup function which then removes the sign from the string

[BenMorel]

Thank you for your PR, this brings an appreciable performance improvement!

Let's improve a few things and merge it!

[BenMorel]

Suggested change

	$unscaledValue = self::leanCleanUp(($sign ?? ''), $integral . $fractional);
	$unscaledValue = self::cleanUp($sign, $integral . $fractional);

After leanCleanUp has been renamed to cleanUp.

[BenMorel]

Suggested change

	'(?<integral>[0-9]+)?' .
	'(?<point>\.)?' .
	'(?<fractional>[0-9]+)?' .
	'(?:[eE](?<exponent>[\-\+]?[0-9]+))?' .
	'(?<integral>[0-9]+)?' .
	'(?<point>\.)?' .
	'(?<fractional>[0-9]+)?' .
	'(?:[eE](?<exponent>[\-\+]?[0-9]+))?' .

[BenMorel]

Suggested change

	'/^' .
	'(?<sign>[\-\+])?' .
	'(?<numerator>[0-9]+)' .
	'\/?' .
	'(?<denominator>[0-9]+)' .
	'$/';
	'/^' .
	'(?<sign>[\-\+])?' .
	'(?<numerator>[0-9]+)' .
	'\/?' .
	'(?<denominator>[0-9]+)' .
	'$/';

[BenMorel]

Spaces + private:

Suggested change

	/**
	* Throws a NumberFormatException for the given value.
	* @psalm-pure
	*/
	protected static function throwException(string $value) : void {
	/**
	* Throws a NumberFormatException for the given value.
	*
	* @psalm-pure
	*/
	private static function throwException(string $value) : void {

[BenMorel]

Suggested change

	$integral = self::leanCleanUp(($sign ?? ''), $integral);
	$integral = self::cleanUp($sign, $integral);

After leanCleanUp has been renamed to cleanUp.

[SebastienDug]

Hello again, Sorry for the delay, The changes requested have been applied and the branch has been synched. Thanks, Sebastien Duguay

[BenMorel]

Thank you, @SebastienDug!

[BenMorel]

Released as 0.12.1.

[SebastienDug]

Good to hear. I will reach out if we find other issues we could improve upon. Thanks, Sebastien Duguay