Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 7-digit postal codes in Egypt #14

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Sep 2, 2024

The new Egypt Postal code system depends on assigning 7 digit postal code number to every block of buildings, which assure better accuracy of identifying the postal code.

https://epostalmap.com/en/

Then new Egypt Postal code system depends on assigning 7 digit postal code number to every block of buildings, which assure better accuracy of identifying the postal code.

https://epostalmap.com/en/
@BenMorel
Copy link
Member

BenMorel commented Sep 4, 2024

Hi @faustbrian, thanks for your PR!

The site you linked to is not an official website, and I'm having trouble finding information about 7-digit postcodes.
I tried the Egypt Post website, but this page doesn't work for me:

https://egyptpost.gov.eg/ar-eg/home/eservices/find-postal-code/

Do you have an official source of information?

@faustbrian
Copy link
Contributor Author

faustbrian commented Sep 5, 2024

@BenMorel I don't really have any official sources. The closest would probably be https://www.upu.int/UPU/media/upu/PostalEntitiesFiles/addressingUnit/egyEn.pdf but that's not official from a government.

We started to notice this because we use this package in a logistics product and customers recently started to use 7 digit postal codes for Egypt consignments instead of 5 digit postal codes, so currently we have a workaround that if validation fails for 5 digits we check for 7 digits and that works. All the third-party vendors we integrate also started to recognize 7 digit postal codes for Egypt.

@BenMorel
Copy link
Member

Thank you, the upu.int source looks good to me. Can you please change this sentence in the class docblock:

Postcodes consist of 5 digits, without separator.

Postcodes consist of 5 or 7 digits, without separator.

and add a link to the PDF above in the docblock as well?

@faustbrian
Copy link
Contributor Author

@BenMorel done

@BenMorel BenMorel merged commit 59236ee into brick:master Sep 15, 2024
8 checks passed
@BenMorel
Copy link
Member

Thank you, @faustbrian!

@BenMorel
Copy link
Member

Released as 0.3.2.

@faustbrian faustbrian deleted the patch-1 branch September 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants