Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new zip-code validation format for Ireland #7

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Adds new zip-code validation format for Ireland #7

merged 3 commits into from
Feb 22, 2021

Conversation

nigobo
Copy link
Contributor

@nigobo nigobo commented Feb 22, 2021

Fixes issue with A98F625 not validating correctly

@BenMorel
Copy link
Member

Hi, can you add this postcode to the tests?

@BenMorel BenMorel merged commit a5b970b into brick:master Feb 22, 2021
@BenMorel
Copy link
Member

Thanks! By the way, as a side effect this change accepts postcodes in format ANW ANNN as well, is this format valid?

@nigobo
Copy link
Contributor Author

nigobo commented Feb 22, 2021

As I understand it it looks ok. Eircode

Screenshot 2021-02-22 at 14 43 04

@BenMorel
Copy link
Member

Thank you. Released as 0.2.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nigobo @BenMorel