Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional character to GBFormatter alphaIn #9

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Add additional character to GBFormatter alphaIn #9

merged 2 commits into from
Jul 10, 2022

Conversation

chris-ware
Copy link
Contributor

This adds support for postcodes ending in a C such as TQ12 6QC which is a valid postcode: https://www.devon.gov.uk/communities/assets/stover-country-park

@BenMorel
Copy link
Member

Hi, thank you for your PR! Please add a test here and I'll merge it.

@chris-ware
Copy link
Contributor Author

@BenMorel Hopefully I've done as requested, tests now pass instead of failing where they were testing agains C being in the inwards code.

@BenMorel
Copy link
Member

Thank you, just one thing: can the C only be at the end? Or anywhere in the inward code?

@chris-ware
Copy link
Contributor Author

@BenMorel I believe the C can be in any position in the inward code

@BenMorel BenMorel merged commit a58e510 into brick:master Jul 10, 2022
@BenMorel
Copy link
Member

BenMorel commented Jul 10, 2022 •
edited
Loading

Thank you! Released as 0.2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-ware @BenMorel