Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] support public readonly properties, fixes #27 #28

Merged
merged 7 commits into from
Jan 21, 2023
Merged

[master] support public readonly properties, fixes #27 #28

merged 7 commits into from
Jan 21, 2023

Conversation

AnnaDamm
Copy link
Contributor

@AnnaDamm AnnaDamm commented Dec 8, 2022

See #27

@AnnaDamm
Copy link
Contributor Author

@BenMorel Could you have a look at this PR, please? :-)

BenMorel
BenMorel requested changes Dec 23, 2022
View reviewed changes
Copy link
Member

@BenMorel BenMorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 🫶

src/Internal/ObjectExporter/AnyObjectExporter.php Outdated Show resolved Hide resolved
src/Internal/ObjectExporter/AnyObjectExporter.php Outdated Show resolved Hide resolved
src/Internal/ObjectExporter/AnyObjectExporter.php Outdated Show resolved Hide resolved
tests/Classes/PublicReadonlyPropertiesWithConstructor.php Outdated Show resolved Hide resolved
@BenMorel
Copy link
Member

BenMorel commented Jan 6, 2023

@AnnaDamm Do you have time to apply suggestions? Do you want me to take over?

@AnnaDamm
Copy link
Contributor Author

AnnaDamm commented Jan 6, 2023

Hey @BenMorel! Sorry, I have been on vacation over the past 2 weeks and will be able to change the PR next week

@AnnaDamm AnnaDamm requested a review from BenMorel January 10, 2023 11:04
@BenMorel BenMorel merged commit f62743f into brick:master Jan 21, 2023
@BenMorel
Copy link
Member

Thank you, @AnnaDamm !

@BenMorel
Copy link
Member

Released as 0.3.8.

BenMorel pushed a commit that referenced this pull request May 10, 2024
@AnnaDamm @BenMorel
[master] support public readonly properties, fixes #27 (#28)
fd0e05a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@func0der func0der func0der approved these changes

@pascalheidmann pascalheidmann pascalheidmann approved these changes

@BenMorel BenMorel Awaiting requested review from BenMorel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AnnaDamm @BenMorel @func0der @pascalheidmann @annadamm-check24