Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new check: Amazon WorkSpaces - Check encryption at rest #141

Closed
jonjozwiak opened this issue Mar 25, 2020 · 5 comments
Closed

Add new check: Amazon WorkSpaces - Check encryption at rest #141

jonjozwiak opened this issue Mar 25, 2020 · 5 comments
Labels
fast-lane New check contributions good first issue Good for newcomers stale

Comments

@jonjozwiak
Copy link
Contributor

WorkSpaces should have both root and user volumes encrypted at rest.

RootVolumeEncryptionEnabled / UserVolumeEncryptionEnabled: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-workspaces-workspace.html

This is not supported in Terraform as of yet, but coming with an aws_workspaces_workspace and root_volume_encryption_enabled/user_volume_encryption_enabled:
hashicorp/terraform-provider-aws#11608
hashicorp/terraform-provider-aws#434

@schosterbarak schosterbarak added good first issue Good for newcomers fast-lane New check contributions labels Mar 25, 2020
@Tensho
Copy link

Tensho commented Mar 26, 2020

Hi 🙂 JFYI, I'd be cautious about mandatory workspace volume encription because it blocks image creation and you can't disable encryption at the moment.
https://docs.aws.amazon.com/workspaces/latest/adminguide/encrypt-workspaces.html#encryption_limits

@jonjozwiak
Copy link
Contributor Author

It's good to be aware of those limitations. For the image creation use case, is this typically an administrator creating an image that is then deployed for many users? Are there times when a users machine would be used to create an image?

@Tensho
Copy link

Tensho commented Mar 28, 2020

Yes, administrator.
Not necessary, user workspace could be used to bake an image. However, administrator usually works with test workspace to bake and then distribute an image.

@stale
Copy link

stale bot commented Mar 23, 2021

Thanks for contributing to Checkov! We've automatically marked this issue as stale to keep our issues list tidy, because it has not had any activity for 6 months. It will be closed in 14 days if no further activity occurs. Commenting on this issue will remove the stale tag. If you want to talk through the issue or help us understand the priority and context, feel free to add a comment or join us in the Checkov slack channel at https://slack.bridgecrew.io
Thanks!

@stale stale bot added the stale label Mar 23, 2021
@stale
Copy link

stale bot commented Apr 6, 2021

Closing issue due to inactivity. If you feel this is in error, please re-open, or reach out to the community via slack: https://slack.bridgecrew.io Thanks!

@stale stale bot closed this as completed Apr 6, 2021
nimrodkor pushed a commit that referenced this issue Apr 8, 2021
nimrodkor pushed a commit that referenced this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-lane New check contributions good first issue Good for newcomers stale
Projects
None yet
Development

No branches or pull requests

3 participants