Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): Update the SARIF schema URL #6304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mikaciu
Copy link

@Mikaciu Mikaciu commented May 14, 2024

User description

Linked to oasis-tcs/sarif-spec#599

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

After oasis-tcs/sarif-spec#599, the URL for the SARIF schema has changed.

This PR updates this URL in all locations of the repo.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Updates the SARIF schema URL across multiple files in the project. Modifies the $schema field in SARIF-related code, tests, and documentation to point to the new location of the SARIF schema.

TopicDetails
SARIF Schema Update Updates the SARIF schema URL from the old 'master' branch to the new 'main' branch location
Modified files (6)
  • docs/8.Outputs/SARIF.md
  • tests/sca_package_2/test_output_reports.py
  • tests/openapi/runner/resources/runner_results/results.sarif
  • tests/common/output/test_sarif_report.py
  • tests/sca_image/test_output_reports.py
  • checkov/common/output/sarif.py
Latest Contributors(2)
UserCommitDate
47212872+EmmaVinen@use...feat-general-allow-too...September 11, 2024
62605534+SteveVaknin@u...fix-general-fix-change...May 06, 2024
This pull request is reviewed by Baz. Join @Mikaciu and the rest of your team on (Baz).

@ChananM
Copy link
Contributor

ChananM commented Dec 8, 2024

Hi @Mikaciu, thank you for your contribution!
Please update the branch and revise the PR title to adhere to the repo naming conventions. I suggest fix(general)

@Mikaciu Mikaciu changed the title Update the SARIF schema URL fix(general): Update the SARIF schema URL Dec 27, 2024
@Mikaciu
Copy link
Author

Mikaciu commented Dec 27, 2024

PR title updated & branch rebased on the bridgecrewio/checkov main branch ;)

@AdamDev
Copy link
Contributor

AdamDev commented Jan 5, 2025

Hi @Mikaciu, thank you for your contribution!
Could you please pull from main and push again, so we can proceed with this PR?

@MaryArmaly
Copy link
Contributor

Hey @Mikaciu,
Could you please merge the latest changes from the main branch into your branch again? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants