Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): Fix accidentally merged categories in prompt.py #6449

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

InputUsername
Copy link

@InputUsername InputUsername commented Jun 14, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

The missing comma caused backup_and_recovery and convention to be merged into one category preventing either category from being specified.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Fixes a syntax error in the CATEGORIES list within the Prompt class by adding a missing comma between "backup_and_recovery" and "convention".

TopicDetails
Category List Fix Corrects a syntax error in the CATEGORIES list by adding a missing comma, separating backup_and_recovery and convention categories.
Modified files (1)
  • checkov/common/util/prompt.py
Latest Contributors(2)
UserCommitDate
gruebelImprove-type-hints-in-...May 08, 2022
17982571+jmeredith16@u...Check-Generator-CLI-Pr...November 08, 2021
This pull request is reviewed by Baz. Join @InputUsername and the rest of your team on (Baz).

@InputUsername InputUsername changed the title fix(general) Add missing comma in prompt.py fix(general) Fix accidentally merged categories in prompt.py Jun 14, 2024
@itai1357 itai1357 changed the title fix(general) Fix accidentally merged categories in prompt.py fix(general): Fix accidentally merged categories in prompt.py Jul 18, 2024
@itai1357
Copy link
Contributor

Hi @InputUsername . can you please make sure your source branch is up-to-date with bridgecrewio:main?

@InputUsername
Copy link
Author

@itai1357 is this OK or do you want me to rebase?

The missing comma caused `backup_and_recovery` and `convention` to be merged
@AdamDev
Copy link
Contributor

AdamDev commented Jan 5, 2025

Hi @InputUsername just pull from main branch and push back.

@InputUsername
Copy link
Author

@AdamDev done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants