-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(general): Fix accidentally merged categories in prompt.py #6449
Open
InputUsername
wants to merge
3
commits into
bridgecrewio:main
Choose a base branch
from
InputUsername:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InputUsername
had a problem deploying
to
scan-security
June 14, 2024 07:59 — with
GitHub Actions
Failure
InputUsername
changed the title
fix(general) Add missing comma in prompt.py
fix(general) Fix accidentally merged categories in prompt.py
Jun 14, 2024
InputUsername
had a problem deploying
to
scan-security
July 14, 2024 12:45 — with
GitHub Actions
Failure
itai1357
changed the title
fix(general) Fix accidentally merged categories in prompt.py
fix(general): Fix accidentally merged categories in prompt.py
Jul 18, 2024
Hi @InputUsername . can you please make sure your source branch is up-to-date with bridgecrewio:main? |
InputUsername
had a problem deploying
to
scan-security
July 18, 2024 12:25 — with
GitHub Actions
Failure
@itai1357 is this OK or do you want me to rebase? |
The missing comma caused `backup_and_recovery` and `convention` to be merged
InputUsername
had a problem deploying
to
scan-security
August 17, 2024 13:49 — with
GitHub Actions
Failure
Hi @InputUsername just pull from main branch and push back. |
InputUsername
requested a deployment
to
scan-security
January 5, 2025 12:59 — with
GitHub Actions
Waiting
@AdamDev done! |
InputUsername
requested a deployment
to
scan-security
January 7, 2025 13:54 — with
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The missing comma caused
backup_and_recovery
andconvention
to be merged into one category preventing either category from being specified.Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Fixes a syntax error in the
CATEGORIES
list within thePrompt
class by adding a missing comma between"backup_and_recovery"
and"convention"
.CATEGORIES
list by adding a missing comma, separatingbackup_and_recovery
andconvention
categories.Modified files (1)
Latest Contributors(2)