Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): revert comment out ARM test #6882

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Nov 28, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Re-enable previously commented out ARM tests in test_yaml_policies.py to ensure comprehensive test coverage for Azure configurations. The tests include AzureSpringCloudConfigWithVnet, AzureMLWorkspacePublicNetwork, SynapseLogMonitoringEnabledForSQLPool, SynapseSQLPoolHasVulnerabilityAssessment, and SynapseWorkspaceHasExtendedAuditLogs. These tests verify the correct application of security and network policies in Azure environments.

TopicDetails
ARM Test Re-enablement Re-enable ARM tests for Azure configurations.
Modified files (1)
  • tests/arm/graph_builder/checks/test_yaml_policies.py
Latest Contributors(2)
UserCommitDate
lirshindalmanfix-general-fix_memory...November 28, 2024
taviassaffeat-azure-add-new-pol...November 17, 2024
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

@pazbechor pazbechor self-requested a review November 28, 2024 15:59
@lirshindalman lirshindalman merged commit 5728737 into main Nov 28, 2024
42 checks passed
@lirshindalman lirshindalman deleted the fix_comment_out branch November 28, 2024 16:29
Saarett pushed a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants