Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform_plan): run post_runner after get_enriched_resources for terraform_plan #6883

Merged

Conversation

lirshindalman
Copy link
Contributor

@lirshindalman lirshindalman commented Dec 1, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Reorder the execution of run_post_runner in runner_registry.py to occur after get_enriched_resources for improved report handling in the terraform_plan context.

TopicDetails
Post Runner Execution Reorder the execution of run_post_runner to ensure it runs after get_enriched_resources for better report handling.
Modified files (1)
  • checkov/common/runners/runner_registry.py
Latest Contributors(2)
UserCommitDate
AdamVarsan@gmail.comfeat-arm-unsupported-m...October 15, 2024
gruebelchore-update-cloudspla...September 18, 2024
This pull request is reviewed by Baz. Join @lirshindalman and the rest of your team on (Baz).

Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🚀

@lirshindalman lirshindalman merged commit 0d71c6f into main Dec 1, 2024
42 checks passed
@lirshindalman lirshindalman deleted the PCSUP-25952-run-run_post_runner-after-enriched_resources branch December 1, 2024 09:31
Saarett pushed a commit that referenced this pull request Dec 1, 2024
… terraform_plan (#6883)

* run post_runner after get_enriched_resources for terraform_plan

* run post_runner after get_enriched_resources for terraform_plan

* run post_runner after get_enriched_resources for terraform_plan
Saarett pushed a commit that referenced this pull request Dec 1, 2024
… terraform_plan (#6883)

* run post_runner after get_enriched_resources for terraform_plan

* run post_runner after get_enriched_resources for terraform_plan

* run post_runner after get_enriched_resources for terraform_plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants