Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes): fix json file parsing #6891

Merged
merged 9 commits into from
Dec 5, 2024
Merged

fix(kubernetes): fix json file parsing #6891

merged 9 commits into from
Dec 5, 2024

Conversation

SteveVaknin
Copy link
Contributor

@SteveVaknin SteveVaknin commented Dec 4, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances JSON file parsing in the Kubernetes module by improving handling of large files and updating line number tracking. Introduces a CustomDecoder class for efficient processing of large JSON files, and updates the existing SafeLineLoader to use standardized constants for start and end line numbers.

TopicDetails
JSON Parsing Upgrade Improves JSON file parsing capabilities, particularly for large files, and standardizes line number tracking
Modified files (1)
  • checkov/kubernetes/parser/k8_json.py
Latest Contributors(2)
UserCommitDate
bo156feat-general-Add-resou...July 19, 2023
gruebelfeat-general-support-U...July 10, 2023
Code Optimization Refactors existing code to use constants and improves error handling
Modified files (1)
  • checkov/kubernetes/parser/k8_json.py
Latest Contributors(2)
UserCommitDate
bo156feat-general-Add-resou...July 19, 2023
gruebelfeat-general-support-U...July 10, 2023
This pull request is reviewed by Baz. Join @SteveVaknin and the rest of your team on (Baz).

@SteveVaknin SteveVaknin merged commit 24f8f90 into main Dec 5, 2024
38 checks passed
@SteveVaknin SteveVaknin deleted the bugfix/k8s/json branch December 5, 2024 09:34
Saarett pushed a commit that referenced this pull request Dec 5, 2024
* Fix(kubernetes): fix json parsing

* fix decoder

* fix lint

* use consts

* fix reintoduce parts

* remove duplicates

* usage fix

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants