-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubernetes): fix json file parsing #6891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 07:18 — with
GitHub Actions
Waiting
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 12:14 — with
GitHub Actions
Waiting
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 12:35 — with
GitHub Actions
Waiting
bo156
reviewed
Dec 4, 2024
omriyoffe-panw
approved these changes
Dec 4, 2024
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 14:14 — with
GitHub Actions
Waiting
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 15:11 — with
GitHub Actions
Waiting
SteveVaknin
requested a deployment
to
scan-security
December 4, 2024 15:19 — with
GitHub Actions
Waiting
SteveVaknin
temporarily deployed
to
scan-security
December 4, 2024 15:59 — with
GitHub Actions
Inactive
ChanochShayner
approved these changes
Dec 5, 2024
SteveVaknin
temporarily deployed
to
scan-security
December 5, 2024 08:18 — with
GitHub Actions
Inactive
Saarett
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Fix(kubernetes): fix json parsing * fix decoder * fix lint * use consts * fix reintoduce parts * remove duplicates * usage fix * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances JSON file parsing in the Kubernetes module by improving handling of large files and updating line number tracking. Introduces a
CustomDecoder
class for efficient processing of large JSON files, and updates the existingSafeLineLoader
to use standardized constants for start and end line numbers.Modified files (1)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)