Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Fix for multiple checks #6933

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Jan 3, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes #6931
Fixes #6927

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances the StorageLocalUsers check for Azure storage accounts and improves the StateLock check for Terraform S3 backend. Updates the corresponding test cases to cover new scenarios and edge cases. Adds a new Terraform configuration file for testing partial configurations.

TopicDetails
StateLock Enhances the StateLock check to handle empty S3 backend configurations
Modified files (2)
  • tests/terraform/checks/terraform/terraform/resources/lock/unknown_partialconfig.tf
  • checkov/terraform/checks/terraform/terraform/StateLock.py
Latest Contributors(0)
UserCommitDate
StorageLocalUsers Improves the StorageLocalUsers check to handle SFTP-enabled storage accounts and updates related test cases
Modified files (3)
  • tests/terraform/checks/resource/azure/test_StorageLocalUsers.py
  • tests/terraform/checks/resource/azure/example_StorageLocalUsers/main.tf
  • checkov/terraform/checks/resource/azure/StorageLocalUsers.py
Latest Contributors(1)
UserCommitDate
tsmithv11feat-terraform-Add-che...September 12, 2024
This pull request is reviewed by Baz. Join @tsmithv11 and the rest of your team on (Baz).

@tsmithv11 tsmithv11 marked this pull request as ready for review January 4, 2025 00:31
Copy link
Contributor

@talazuri talazuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsmithv11 tsmithv11 merged commit c6e36f9 into main Jan 6, 2025
35 of 36 checks passed
@tsmithv11 tsmithv11 deleted the multiple-check-fixes-jan25 branch January 6, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants