Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the check for data in prestart.js #487

Merged
merged 1 commit into from
May 30, 2018
Merged

Fix the check for data in prestart.js #487

merged 1 commit into from
May 30, 2018

Conversation

radu-matei
Copy link
Contributor

@radu-matei radu-matei commented May 30, 2018 •
edited
Loading

It appears to be a bug in prestart.js that only returns the script if the file is empty.

@technosophos technosophos added the bug Something isn't working label May 30, 2018
@technosophos
Copy link
Contributor

Yes, definitely a bug.

technosophos
technosophos approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technosophos technosophos merged commit 7787677 into brigadecore:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radu-matei @technosophos