s3io.Reader: reissue request on ECONNRESET #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
force-pushed
the
s3-reader-retry
branch
from
23ff716 to
3f7c129
Compare
If a "connection error" reset is encountered while reading a s3 object attempt to restart the connection and resume read at the current offset. This solves a bug found when trying to ingest several s3 hosted log files: several files will stop ingesting with the error "connection reset by peer". There seems to be a curious behavior of the s3 service that happens when a single session maintains numerous long-running download connections to various objects in a bucket- the service appears to reset connections at random. See: aws/aws-sdk-go#1242 Closes #2005
mattnibs
force-pushed
the
s3-reader-retry
branch
from
3f7c129 to
2042f45
Compare
nwt
approved these changes
Feb 11, 2021
alfred-landrum
approved these changes
Feb 11, 2021
mattnibs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a "connection error" reset is encountered while reading a s3 object attempt
to restart the connection and resume read at the current offset.
This solves a bug found when trying to ingest several s3 hosted log files:
several files will stop ingesting with the error "connection reset by peer".
There seems to be a curious behavior of the s3 service that happens when
a single session maintains numerous long-running download connections to
various objects in a bucket- the service appears to reset connections at
random.
See: aws/aws-sdk-go#1242
Closes #2005