Add zed.Value.Under parameter to avoid allocation #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value.Under allocates memory on any call that does not return the
receiver. This becomes spendy in runtime/expr.DotExpr.Eval on workloads
that access fields of records with named types. Add a parameter to
Under that, when not nil, points to a Value to use in lieu of
allocating.
goos: darwin
goarch: arm64
pkg: github.com/brimdata/zed
| before.txt | after.txt |
| sec/op | sec/op vs base |
ValueUnder/primitive-10 0.9348n ± 0% 0.9331n ± 1% ~ (p=0.617 n=10)
ValueUnder/named-10 27.480n ± 0% 6.385n ± 1% -76.76% (p=0.000 n=10)
geomean 5.068n 2.441n -51.84%
mccanne
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value.Under allocates memory on any call that does not return the receiver. This becomes spendy in runtime/expr.DotExpr.Eval on workloads that access fields of records with named types. Add a parameter to Under that, when not nil, points to a Value to use in lieu of allocating.