Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Status endpoint is GET, not POST #4766

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Query Status endpoint is GET, not POST #4766

merged 1 commit into from
Sep 7, 2023

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Sep 7, 2023

I bumped into this while following the user-facing API docs during verification.

@philrz philrz requested review from mattnibs and nwt September 7, 2023 14:37
@philrz philrz self-assigned this Sep 7, 2023
mattnibs
mattnibs approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mattnibs mattnibs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch.

@philrz philrz merged commit 214ea42 into main Sep 7, 2023
4 checks passed
@philrz philrz deleted the query-status-get branch September 7, 2023 15:10
@philrz philrz linked an issue Sep 7, 2023 that may be closed by this pull request
Failed response over API looks like success #4215
Closed
@philrz philrz mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnibs mattnibs mattnibs approved these changes

@nwt nwt Awaiting requested review from nwt

Assignees

@philrz philrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed response over API looks like success
2 participants
@philrz @mattnibs