Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSV support #4891

Merged
merged 2 commits into from
Nov 29, 2023
Merged

TSV support #4891

merged 2 commits into from
Nov 29, 2023

Conversation

mattnibs
Copy link
Collaborator

Add tsv for support for both input and output. Also support auto-detection of tsv input.

Closes #4746

@mattnibs mattnibs requested a review from a team November 20, 2023 19:25
@philrz
Copy link
Contributor

philrz commented Nov 20, 2023

I just tested out this branch at commit 86b9fdb and it worked great for me with the pbpaste | zq -Z - Google Sheets use case described in #4746. So it's a functional 👍 for me!

Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add MediaTypeTSV = "application/tab-separated-values", wire it up, add tests in services/ztests/, add it to docs/lake/api.md.
  2. Add TSV to the Input Formats section in docs/commands/zq.md.

zio/anyio/lookup.go Outdated Show resolved Hide resolved
zio/anyio/reader.go Outdated Show resolved Hide resolved
zio/anyio/reader.go Outdated Show resolved Hide resolved
zio/anyio/reader.go Outdated Show resolved Hide resolved
Add tsv for support for both input and output. Also support auto-detection of
tsv input.

Closes #4746
api/mime.go Outdated Show resolved Hide resolved
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
@mattnibs mattnibs merged commit b84255c into main Nov 29, 2023
4 checks passed
@mattnibs mattnibs deleted the tsv branch November 29, 2023 17:46
zmajeed pushed a commit to zmajeedforks/zed that referenced this pull request Dec 6, 2023
Add tsv for support for both input and output. Also support auto-detection of
tsv input.

Closes brimdata#4746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSV read/write
3 participants