Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zq: fix panic when trying to read from a pool #4936

Merged
merged 2 commits into from
Dec 14, 2023
Merged

zq: fix panic when trying to read from a pool #4936

merged 2 commits into from
Dec 14, 2023

Conversation

mattnibs
Copy link
Collaborator

Closes #4935

@mattnibs mattnibs requested a review from a team December 13, 2023 21:27
nwt
nwt approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test. As it demonstrates, the error message here is pretty confusing but let's fix that separately.

@mattnibs
Copy link
Collaborator Author

I added a test. As it demonstrates, the error message here is pretty confusing but let's fix that separately.

@nwt thanks. I agree about the confusing error message but a better fix would involve a lot more effort and I reasoned that we have bigger fish to fry right now.

@mattnibs mattnibs merged commit 59b72d8 into main Dec 14, 2023
3 checks passed
@mattnibs mattnibs deleted the zq-from-panic branch December 14, 2023 17:09
@philrz philrz mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEGV when incorrectly attempting to "from" a pool with zq
2 participants
@mattnibs @nwt