Log canceled client requests at info level #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"zed serve" logs canceled client requests (specifically, those that end
due to a context.Canceled error appearing to originate from the request
context) at warn level, which includes a stack trace, with an alarming
message.
{
"level":"warn",
"ts":1702997509.358625,
"logger":"core",
"msg":"Error",
"request_id":"2ZlXC74Oeg2zEXQXX8ol8Ma1Lyd",
"status":500,
"error":"context canceled",
"stacktrace":"..."
}
Change the level to info, thereby omitting the stack trace, and change
the message to one less alarming.
{
"level":"info",
"ts":1702998051.5594501,
"logger":"core",
"msg":"Request context canceled",
"request_id":"2ZlYICXG8lrypWxyIxUBoM84qjT"
}
mattnibs
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"zed serve" logs canceled client requests (specifically, those that end due to a context.Canceled error appearing to originate from the request context) at warn level, which includes a stack trace, with an alarming message.
Change the level to info, thereby omitting the stack trace, and change the message to one less alarming.
Closes #4941.