Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keepalive endpoint #4963

Closed
wants to merge 1 commit into from
Closed

Add keepalive endpoint #4963

wants to merge 1 commit into from

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jan 2, 2024 •
edited
Loading

This is used by Zui to prevent orhpaned Zed processes by exiting when a client stops polling the keepalive endpoint.

Closes #4863

@mattnibs mattnibs requested a review from a team January 2, 2024 21:09
nwt
nwt reviewed Jan 2, 2024
View reviewed changes
service/core.go Outdated Show resolved Hide resolved
@mattnibs mattnibs force-pushed the stayalive branch 5 times, most recently from 2705053 to e129225 Compare January 3, 2024 19:14
@mattnibs mattnibs requested a review from nwt January 3, 2024 19:16
@mattnibs mattnibs force-pushed the stayalive branch 3 times, most recently from f569eb2 to 6ff7dc4 Compare January 4, 2024 20:36
@philrz philrz requested a review from mccanne January 4, 2024 20:45
@mattnibs mattnibs force-pushed the stayalive branch 2 times, most recently from fcb1485 to 7d99935 Compare January 5, 2024 18:37
@mattnibs mattnibs changed the title Add stayalive endpoint Add keepalive endpoint Jan 5, 2024
@mattnibs
Add keepalive endpoint
e397900 
This is used by Zui to prevent orhpaned Zed processes by exiting when a client
stops polling the keepalive endpoint.

Closes 4863
@mccanne
Copy link
Collaborator

mccanne commented Jan 6, 2024 •
edited
Loading

Cool! I think /keepalive should return the reason the server exits but not sure how to wire that up, e.g., "zed serve exited on SIGINT". Not a big deal and could do this later if warranted.

@mattnibs
Copy link
Collaborator Author

mattnibs commented Jan 8, 2024

Closing, going in a different direction: brimdata/zui#2956

@mattnibs mattnibs closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwt nwt Awaiting requested review from nwt

@mccanne mccanne Awaiting requested review from mccanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "long poll" lake API endpoint
3 participants
@mattnibs @mccanne @nwt