Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zq: Correct error message when no source is found #5119

Merged
merged 1 commit into from
May 31, 2024
Merged

zq: Correct error message when no source is found #5119

merged 1 commit into from
May 31, 2024

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented May 2, 2024

This commit fixes an issue where the wrong error message was returned for a single argument zq invocation where the argument is a valid Zed query but the query contains no source.

Closes #5110

@mattnibs mattnibs requested a review from a team May 2, 2024 00:35
@mattnibs mattnibs force-pushed the no-source-error branch from d9f77ba to f62fbd2 Compare May 2, 2024 00:37
philrz
philrz reviewed May 2, 2024
View reviewed changes
@mattnibs mattnibs changed the base branch from main to positional-sem-errors May 14, 2024 18:04
@philrz philrz requested a review from a team May 14, 2024 18:29
philrz
philrz reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattnibs: Thanks for adjusting the error message. I'm good with these improvements, but since there's actual code changes involved here it'd probably be better for the official approval to come from @nwt.

@nwt nwt force-pushed the positional-sem-errors branch 2 times, most recently from e8f887c to 0adda42 Compare May 31, 2024 20:27
@nwt nwt force-pushed the no-source-error branch from 3e2c508 to 9e91c3e Compare May 31, 2024 20:42
@mattnibs mattnibs force-pushed the positional-sem-errors branch from 0adda42 to df5e345 Compare May 31, 2024 20:46
@nwt nwt changed the base branch from positional-sem-errors to main May 31, 2024 20:46
@nwt nwt changed the base branch from main to positional-sem-errors May 31, 2024 20:47
@nwt nwt force-pushed the no-source-error branch 2 times, most recently from 4a8c553 to d0596e8 Compare May 31, 2024 20:53
@mattnibs mattnibs force-pushed the positional-sem-errors branch from df5e345 to 6a7a54b Compare May 31, 2024 21:06
@nwt nwt force-pushed the no-source-error branch from d0596e8 to a2b2495 Compare May 31, 2024 21:09
@mattnibs mattnibs force-pushed the positional-sem-errors branch from 6a7a54b to 280ebf1 Compare May 31, 2024 21:15
@nwt nwt force-pushed the no-source-error branch from a2b2495 to 6526f1d Compare May 31, 2024 21:18
Base automatically changed from positional-sem-errors to main May 31, 2024 21:22
@mattnibs @nwt
zq: Correct error message when no source is found
5c3e274 
This commit fixes an issue where the wrong error message was returned for a
single argument zq invocation where the argument is a valid Zed query but the
query contains no source.

Closes #5110
@nwt nwt force-pushed the no-source-error branch from 6526f1d to 5c3e274 Compare May 31, 2024 21:28
@mattnibs mattnibs merged commit 8e69667 into main May 31, 2024
3 checks passed
@mattnibs mattnibs deleted the no-source-error branch May 31, 2024 22:00
@philrz philrz mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz left review comments

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit stdin support / Unintuitive behaviour when omitting '-'
3 participants
@mattnibs @nwt @philrz