Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zed manage: Add -pool flag #5164

Merged
merged 1 commit into from
Jul 8, 2024
Merged

zed manage: Add -pool flag #5164

merged 1 commit into from
Jul 8, 2024

Conversation

mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Jul 2, 2024

Add a -pool flag to zed manage that specifies a pool to run Zed manage on.

@mattnibs
zed manage: Add -pool flag
d70507c 
Add a -pool flag to zed manage that specifies a pool to run Zed manage
on.
@mattnibs mattnibs requested a review from a team July 2, 2024 22:13
@philrz
Copy link
Contributor

philrz commented Jul 2, 2024

Was it intentional that -use was not picked for this?

@mattnibs
Copy link
Collaborator Author

mattnibs commented Jul 3, 2024

Was it intentional that -use was not picked for this?

I don't think -use it right for this since it can be specified multiple times, also use is ignored by the command.

nwt
nwt approved these changes Jul 8, 2024
View reviewed changes
cmd/zed/internal/lakemanage/manage.go Show resolved Hide resolved
@mattnibs mattnibs merged commit da13345 into main Jul 8, 2024
3 checks passed
@mattnibs mattnibs deleted the manage-pool-flag branch July 8, 2024 19:51
@philrz philrz mentioned this pull request Sep 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrz philrz philrz left review comments

@nwt nwt nwt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattnibs @philrz @nwt