Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer: Fix load unnecessary merge #5200

Merged
merged 1 commit into from
Aug 6, 2024
Merged

optimizer: Fix load unnecessary merge #5200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/optimizer/parallelize.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ func (o *Optimizer) concurrentPath(ops []dag.Op, sortKey order.SortKey) (int, or
}
return k, newKey, false, true, nil
case *dag.Load:
return k, order.Nil, true, true, nil
// XXX At some point Load should have an optimization where if the
// upstream sort is the same as the Load destination sort we
// request a merge and set the Load operator to do a sorted write.
return k, order.Nil, false, false, nil
case *dag.Fork, *dag.Scatter, *dag.Head, *dag.Tail, *dag.Uniq, *dag.Fuse, *dag.Join:
return k, sortKey, true, true, nil
default:
Expand Down