-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open files on windows with FILE_SHARE_DELETE #741
Conversation
I've created a Brim branch that uses this zq, and it shows many clean CI runs on Windows: |
The zql/ |
So zql/zql.go is a generated file from pigeon, which is why I had not updated it. I can make update the 2 use cases in zql_test.go, though. |
A parser's |
Ah, had missed that. My goal was simply to make it easy to |
Address the occasional rename related failures on Windows by using the FILE_SHARE_DELETE flag when opening files on Windows. As noted in #613, this unfortunately requires copying substantial code from the os package, as there's no way to use that flag with the existing os.Open api.
Fixes #613