Fix Zui Tests

brimdata · Dec 20, 2023 · e0e3a7d · e0e3a7d
1 parent 98ae61c
commit e0e3a7d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/apps/zui/src/electron/run-main/boot.ts b/apps/zui/src/electron/run-main/boot.ts
@@ -24,7 +24,7 @@ export async function boot(args: Partial<MainArgs> = {}) {
   // 6. Protocol Handler
   runProtocolHandlers()
   // 7. Start the app
-  app.whenReady().then(() => main.start())
-
+  await app.whenReady()
+  await main.start()
   return main
 }
diff --git a/apps/zui/src/electron/start.test.ts b/apps/zui/src/electron/start.test.ts
@@ -14,14 +14,6 @@ jest.mock("@brimdata/zed-node")
 
 afterEach(teardown)
 
-test("start is called in zed lake", async () => {
-  const appMain = (await main({
-    devtools: false,
-    autoUpdater: false,
-  })) as MainObject
-  expect(appMain.lake.start).toHaveBeenCalledTimes(1)
-})
-
 test("app opens a window on startup", async () => {
   const appMain = (await main({
     devtools: false,

diff --git a/apps/zui/src/test/system/boot.tsx b/apps/zui/src/test/system/boot.tsx
@@ -50,6 +50,7 @@ export async function boot(name: string, args: Partial<BootArgs> = {}) {
     autoUpdater: false,
     singleInstance: false,
   })) as MainObject
+
   await waitFor(async () => fetch(`http://localhost:${lakePort}/version`), {
     timeout: 20_000,
   })

diff --git a/packages/zed-node/src/lake.ts b/packages/zed-node/src/lake.ts
@@ -28,7 +28,7 @@ export class Lake {
   }
 
   addr(): string {
-    return `:${this.port}`;
+    return `localhost:${this.port}`;
   }
 
   start() {
@@ -38,7 +38,7 @@ export class Lake {
     const args = [
       'serve',
       '-l',
-      this.addr(),
+      ':' + this.port,
       '-lake',
       this.root,
       '-log.level=info',