-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaked zqd process on ungraceful brim shutdown #1018
Comments
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
…y mattnibs This is an auto-generated commit with a zq dependency update. The zq PR brimdata/super#1184, authored by @mattnibs, has been merged. zqd: prevent being orphaned by Brim (unix only) Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
Verified on Brim commit I circled back first and became more acquainted with the repro as of Brim GA tagged On macOS, when the app is launched, here I confirm the
The same is true on Linux (Ubuntu 18.04 LTS):
Notice there's other "droppings" seemingly left behind here other than just the On Windows, the What I observed is that if I shot any of those top three tasks labeled "Brim" it behaved effectively like a no-op, i.e. the Brim window either appeared undisturbed or refreshed briefly as if a process went away and was immediately replaced. When I shot the bottom Brim task, the whole set of tasks including the Now on macOS with Brim commit
On Linux with Brim commit
Thanks @mattnibs! |
If brim is ungracefully shutdown the zqd process launched by brim continues on. There should be some functionality in zqd (or mode for running zqd) where zqd will terminate if the parent Brim process ceases to exist.
Steps to reproduce:
kill -9 $brimpid
ps aux | grep zqd
Note: This does not appear to be a problem on the Windows version of Brim.
The text was updated successfully, but these errors were encountered: