Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron upgrade #1044

Closed
alfred-landrum opened this issue Sep 2, 2020 · 1 comment · Fixed by #1106
Closed

Electron upgrade #1044

alfred-landrum opened this issue Sep 2, 2020 · 1 comment · Fixed by #1106
Assignees
Milestone

Comments

@alfred-landrum
Copy link
Contributor

alfred-landrum commented Sep 2, 2020

We should update Electron to most recent stable release, v10.1.1 currently. @jameskerr notes that last time we attempted an Electron upgrade, we had some issues with the Spectron framework, so the Electron update may require updating several other dependencies. (electron-userland/spectron#631)

@philrz
Copy link
Contributor

philrz commented Sep 15, 2020

The plan is to get the work for this prepared at the same time we're doing other work for the v0.18.0 milestone but hold back on merging it. This way we can merge it as we're starting work on the following milestone (presumed v0.19.0) and hence have all of those two weeks to continue testing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants